Skip to content

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Mar 5, 2024

Fixes build failure reported in https://groups.google.com/g/sage-release/c/oTnTrEnB3YU/m/HONTAsE7BQAJ

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link

github-actions bot commented Mar 5, 2024

Documentation preview for this PR (built with commit e1968f2; changes) is ready! 🎉

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kwankyu
Copy link
Collaborator

kwankyu commented Mar 6, 2024

blocker?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 6, 2024

Yes, I support making it a blocker.
Otherwise, we will meet it again in repeated support discussions.

vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 6, 2024
sagemathgh-37543: build/pkgs/sagemath_doc_html/dependencies: Add 'graphs'
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fixes build failure reported in https://groups.google.com/g/sage-
release/c/oTnTrEnB3YU/m/HONTAsE7BQAJ


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37543
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
@vbraun vbraun closed this pull request by merging all changes into sagemath:develop in e417e22 Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants