Skip to content

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 23, 2024

This is an outdated feature no longer in use in the Sage library.

See #37432 for details.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link

Documentation preview for this PR (built with commit b3a8da4; changes) is ready! 🎉

Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 23, 2024

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 30, 2024
sagemathgh-37432: `setup.py`: Remove `lazy_import_cache` use
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

Both versions of the sagelib `setup.py` have code that tries to remove
the "lazy import cache".

The file name of the lazy import cache in `~/.sage` is keyed to
`SAGE_LIB`, so any file name determined at build time is meaningless at
runtime when installation goes through wheel building. We remove this
code.

As `find ~/.sage -name "*-lazy_import*" | xargs ls -lat` shows, it has
not been in use since 2021, as the Sage library no longer uses any
`lazy_import` of `*`. But just in case some downstream / user code uses
it, we reinstate the cache removal code in `build/pkgs/sagelib/spkg-
install.in`

We deprecate the feature in sagemath#37433.

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#37432
Reported by: Matthias Köppe
Reviewer(s): François Bissey
@vbraun vbraun merged commit cde15ac into sagemath:develop Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants