Skip to content

Conversation

marco-perin
Copy link
Contributor

In the documentation for polyhedron constructor, there was a typo where Polyhedron(o) was used when Polyhedron(p) should have been used instead ( the o var was from the same code piece, but from the very previous example ).

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

In the documentation for polyhedron constructor, there was a typo where `Polyhedron(o)` was used when `Polyhedron(p)` should have been used instead ( the `o` var was from the same code piece, but from the very previous example ).
The result of the lines of code have been updated accordingly
@marco-perin marco-perin marked this pull request as draft February 23, 2024 03:05
@marco-perin marco-perin marked this pull request as ready for review February 23, 2024 03:05
@fchapoton fchapoton self-assigned this Feb 23, 2024
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@fchapoton
Copy link
Contributor

you should rather avoid touching the branch once it is positive reviewed, please

@marco-perin
Copy link
Contributor Author

I'm sorry, I thought it needed merging the develop branch for the PR to be closed. I will not touch it again.
Should I revert it or leave it like this?

@fchapoton
Copy link
Contributor

just do nothing

Copy link

Documentation preview for this PR (built with commit 0dd8855; changes) is ready! 🎉

@vbraun vbraun merged commit 1867d68 into sagemath:develop Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants