Skip to content

minor ruff fixes in quadratic forms (C4, UP, PERF) #37400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2024
Merged

minor ruff fixes in quadratic forms (C4, UP, PERF) #37400

merged 2 commits into from
Mar 31, 2024

Conversation

fchapoton
Copy link
Contributor

just a minor cleanup, after ruff suggestions, in quadratic_forms folder

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@tscrim
Copy link
Collaborator

tscrim commented Feb 20, 2024

Note that for a matrix space MS, the result of MS(0) and MS.zero() are different. The former is mutable, but the latter is immutable.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 839b6bd; changes) is ready! 🎉

grhkm21
grhkm21 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@grhkm21 grhkm21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume it's only required for me to verify correctness, not look for additional improvements.

Just a question, what does the C4, UP, PERF mean?

@fchapoton
Copy link
Contributor Author

Thanks a lot. These letter combinations are some of the codes that the linter ruff can check and fix, see https://docs.astral.sh/ruff/rules/

@vbraun vbraun merged commit 44182de into sagemath:develop Mar 31, 2024
@fchapoton fchapoton deleted the ruff_quadratix branch April 1, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@grhkm21 grhkm21 grhkm21 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: quadratic forms t: refactoring
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
5 participants
@fchapoton @tscrim @grhkm21 @vbraun @mkoeppe