Skip to content

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 26, 2024

Broken since 10.2 as noted in https://github.com/sagemath/sage/wiki/Sage-10.2-Release-Tour#known-problems-and-workarounds

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@kwankyu
Copy link
Collaborator

kwankyu commented Mar 22, 2024

This works well. But you may want to rebase it to 1.4.3?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 22, 2024

Yes, I'll push the new release right away.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 22, 2024

Here it is

Copy link

Documentation preview for this PR (built with commit bf9ffbc; changes) is ready! 🎉

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well. Thanks.

@kwankyu
Copy link
Collaborator

kwankyu commented Mar 22, 2024

The pytest failure is unrelated.

@vbraun vbraun merged commit 9d4c642 into sagemath:develop Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants