Skip to content

use Parent for the Pari pseudo-ring #37465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2024
Merged

use Parent for the Pari pseudo-ring #37465

merged 1 commit into from
Mar 31, 2024

Conversation

fchapoton
Copy link
Contributor

switch the Pari pseudoring to use Parent instead of the auld Ring class

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@fchapoton fchapoton force-pushed the Parent_por_Pari_pseudoring branch from 410d6a2 to 559174e Compare February 25, 2024 17:32
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 559174e; changes) is ready! 🎉

mkoeppe
mkoeppe approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbraun vbraun merged commit 57ea357 into sagemath:develop Mar 31, 2024
@fchapoton fchapoton deleted the Parent_por_Pari_pseudoring branch April 1, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mkoeppe mkoeppe mkoeppe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: commutative algebra p: minor / 4 t: refactoring
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @mkoeppe @vbraun @grhkm21