formal deprecation of old group class #37449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

vbraun merged 3 commits into sagemath:develop from fchapoton:deprecate_old_group_class

Mar 31, 2024

Contributor

fchapoton commented Feb 24, 2024

trying to finally get rid of the auld group class

📝 Checklist

The title is concise, informative, and self-explanatory.
The description explains in detail what this PR is about.
I have created tests covering the changes.
I have updated the documentation accordingly.

fchapoton added 2 commits

February 24, 2024 13:16


          formal deprecation of old group class

7c033b6


          fix issue number

39252f4

fchapoton added s: needs review c: group theory t: refactoring labels

mkoeppe reviewed

View reviewed changes

src/sage/groups/additive_abelian/additive_abelian_group.py Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/groups/additive_abelian/additive_abelian_group.py Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/groups/group.pyx Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/groups/old.pyx Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/groups/old.pyx Outdated Show resolved Hide resolved


          fix suggested details

4cff0fe

mkoeppe reviewed

View reviewed changes

src/sage/categories/action.pyx Show resolved Hide resolved

github-actions bot commented Feb 24, 2024

Documentation preview for this PR (built with commit 4cff0fe; changes) is ready! 🎉

vbraun merged commit 3d59d9c into sagemath:develop

github-actions bot removed the s: positive review label

fchapoton deleted the deprecate_old_group_class branch

April 1, 2024 07:31

fchapoton mentioned this pull request

remove the auld historic "Group" class #40349

Merged

2 tasks

vbraun pushed a commit to vbraun/sage that referenced this pull request

sagemathgh-40349: remove the auld historic "Group" class
    
This was deprecated in sagemath#37449

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#40349
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: group theory t: refactoring