Skip to content

fixing ruff UP037 (about type annotation) #37333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2024
Merged

fixing ruff UP037 (about type annotation) #37333

merged 1 commit into from
Feb 25, 2024

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Feb 14, 2024 •
edited
Loading

namely, quotes are no longer needed around type annotations

this only appeared in two files

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 936a403; changes) is ready! 🎉

@fchapoton fchapoton requested a review from tobiasdiez February 19, 2024 20:17
mkoeppe
mkoeppe approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit e2c3fe9 into sagemath:develop Feb 25, 2024
@fchapoton fchapoton deleted the fixin_ruff_UP037 branch February 25, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez Awaiting requested review from tobiasdiez

1 more reviewer

@mkoeppe mkoeppe mkoeppe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
t: refactoring
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @mkoeppe @vbraun