Skip to content

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 13, 2024

The SPKG.rst titles should not have a final dot.

For uniformity, we also strip an initial indefinite article and ensure that the title starts with a capital letter.

By running sage --package create --pypi for several packages and then using git add -p, we update several packages.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Matthias Koeppe added 28 commits March 5, 2024 13:33
Copy link

github-actions bot commented Mar 5, 2024

Documentation preview for this PR (built with commit f4d499a; changes) is ready! 🎉

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kwankyu
Copy link
Collaborator

kwankyu commented Mar 6, 2024

Not related: Presently doc preview link opens in the same tab. This is annoying. How about making the preview link to open in a newtab?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 6, 2024

Thank you!

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 6, 2024

Presently doc preview link opens in the same tab. This is annoying. How about making the preview link to open in a newtab?

Good idea.

@kwankyu
Copy link
Collaborator

kwankyu commented Mar 6, 2024

Presently doc preview link opens in the same tab. This is annoying. How about making the preview link to open in a newtab?

Good idea.

Ah, I forgot again that github does not allow this...

@vbraun vbraun merged commit 1f87f98 into sagemath:develop Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants