Fix random test failures in number_field_element_quadratic
#37306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a "correct" fix because the `DeprecationWarning` is unrelated to the test.
number_field _element_quadratic
|
Documentation preview for this PR (built with commit fdc7fd7; changes) is ready! 🎉 |
|
Thanks! |
number_field _element_quadraticnumber_field _element_quadratic
number_field _element_quadraticnumber_field_element_quadratic
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 18, 2024
sagemathgh-37306: Fix random test failures in `number_field_element_quadratic` Fix sagemath#37296. Add `warnings.filterwarnings` to ignore `DeprecationWarning` in the failing doctest, since it is an unrelated issue and does not affect correctness of the test. To be more specific, the warning only appears when the rounding error will change, i.e. on $n + \frac{1}{2}$ (I believe). Here are some runs: ```python sage: a = QQ.random_element(3, 3); _ = round(a) sage: a = QQ.random_element(3, 3); _ = round(a) sage: a = QQ.random_element(3, 3); _ = round(a) sage: a = QQ.random_element(3, 3); _ = round(a) sage: a = QQ.random_element(3, 3); _ = round(a) sage: a = QQ.random_element(3, 3); _ = round(a) <ipython-input-12-179149e36f01>:1: DeprecationWarning: the default rounding for rationals, currently `away`, will be changed to `even`. See sagemath#35473 for details. a = QQ.random_element(Integer(3), Integer(3)); _ = round(a) sage: a = QQ.random_element(3, 3); _ = round(a) sage: a = QQ.random_element(3, 3); _ = round(a) <ipython-input-14-179149e36f01>:1: DeprecationWarning: the default rounding for rationals, currently `away`, will be changed to `even`. See sagemath#35473 for details. a = QQ.random_element(Integer(3), Integer(3)); _ = round(a) sage: a = QQ.random_element(3, 3); _ = round(a) sage: a = QQ.random_element(3, 3); _ = round(a) ``` URL: sagemath#37306 Reported by: grhkm21 Reviewer(s): Sebastian A. Spindler
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 19, 2024
sagemathgh-37306: Fix random test failures in `number_field_element_quadratic` Fix sagemath#37296. Add `warnings.filterwarnings` to ignore `DeprecationWarning` in the failing doctest, since it is an unrelated issue and does not affect correctness of the test. To be more specific, the warning only appears when the rounding error will change, i.e. on $n + \frac{1}{2}$ (I believe). Here are some runs: ```python sage: a = QQ.random_element(3, 3); _ = round(a) sage: a = QQ.random_element(3, 3); _ = round(a) sage: a = QQ.random_element(3, 3); _ = round(a) sage: a = QQ.random_element(3, 3); _ = round(a) sage: a = QQ.random_element(3, 3); _ = round(a) sage: a = QQ.random_element(3, 3); _ = round(a) <ipython-input-12-179149e36f01>:1: DeprecationWarning: the default rounding for rationals, currently `away`, will be changed to `even`. See sagemath#35473 for details. a = QQ.random_element(Integer(3), Integer(3)); _ = round(a) sage: a = QQ.random_element(3, 3); _ = round(a) sage: a = QQ.random_element(3, 3); _ = round(a) <ipython-input-14-179149e36f01>:1: DeprecationWarning: the default rounding for rationals, currently `away`, will be changed to `even`. See sagemath#35473 for details. a = QQ.random_element(Integer(3), Integer(3)); _ = round(a) sage: a = QQ.random_element(3, 3); _ = round(a) sage: a = QQ.random_element(3, 3); _ = round(a) ``` URL: sagemath#37306 Reported by: grhkm21 Reviewer(s): Sebastian A. Spindler
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 18, 2025
sagemathgh-39486: Finish changing Rational's round method default rounding to even Follow-up to sagemath#35756 . (As is, the warning cannot be suppressed) Related: sagemath#37306, sagemath#21935 There's a little (large??) problem: previously `K2.<sqrt2> = QuadraticField(2); K2(9/2).round()` returns `5` **without** a warning (because sagemath#35756 forget to print the deprecation). Should we add the deprecation first **then** change this next year? ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39486 Reported by: user202729 Reviewer(s): Vincent Neiger
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 21, 2025
sagemathgh-39486: Finish changing Rational's round method default rounding to even Follow-up to sagemath#35756 . (As is, the warning cannot be suppressed) Related: sagemath#37306, sagemath#21935 There's a little (large??) problem: previously `K2.<sqrt2> = QuadraticField(2); K2(9/2).round()` returns `5` **without** a warning (because sagemath#35756 forget to print the deprecation). Should we add the deprecation first **then** change this next year? ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39486 Reported by: user202729 Reviewer(s): Vincent Neiger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #37296.
Add
warnings.filterwarningsto ignoreDeprecationWarningin the failing doctest, since it is an unrelated issue and does not affect correctness of the test.To be more specific, the warning only appears when the rounding error will change, i.e. on$n + \frac{1}{2}$ (I believe). Here are some runs: