use Parent instead of Algebra in finite_gca #37302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscrim
approved these changes
Feb 12, 2024
|
Documentation preview for this PR (built with commit e018ff4; changes) is ready! 🎉 |
|
Thank you |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 18, 2024
sagemathgh-37302: use Parent instead of Algebra in finite_gca This is removing one usage of the auld-class `Algebra` in the modified file Also changing a few minor details in doc and code there, and sorting the imports. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#37302 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 19, 2024
sagemathgh-37302: use Parent instead of Algebra in finite_gca This is removing one usage of the auld-class `Algebra` in the modified file Also changing a few minor details in doc and code there, and sorting the imports. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#37302 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is removing one usage of the auld-class
Algebrain the modified fileAlso changing a few minor details in doc and code there, and sorting the imports.
📝 Checklist