Skip to content

fix relabel for permutation groups #37398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 25, 2024
Merged

fix relabel for permutation groups #37398

merged 5 commits into from
Feb 25, 2024

Conversation

dcoudert
Copy link
Contributor

Fixes #37379.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@dcoudert dcoudert mentioned this pull request Feb 19, 2024
Closed
2 tasks
@dcoudert dcoudert self-assigned this Feb 19, 2024
tscrim
tscrim approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

tscrim
tscrim reviewed Feb 20, 2024
View reviewed changes
@dcoudert
Copy link
Contributor Author

Thank you Travis for the review.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit b3b634c; changes) is ready! 🎉

@vbraun vbraun merged commit 6030e58 into sagemath:develop Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees

@dcoudert dcoudert

Labels
c: graph theory c: group theory t: bug
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.

Graph.relabel() misinterprets elements of .automorphism_group()
4 participants
@dcoudert @tscrim @vbraun @mkoeppe