Skip to content

fix some ruff suggestions in cluster_algebra_quiver #37397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2024
Merged

fix some ruff suggestions in cluster_algebra_quiver #37397

merged 1 commit into from
Feb 25, 2024

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Feb 19, 2024 •
edited
Loading

this was scripted using ruff for the codes UP and C4 in the cluster folder.

Plus a few hand-made changes about pep8

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 6633a9f; changes) is ready! 🎉

tscrim
tscrim approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I will say one comment: I don't really care for the change set(...) to {...}. The latter is very close to a dict construction in Python, leading to a very easy to make error of {} meant to be the empty set.

@vbraun vbraun merged commit 5bda2e2 into sagemath:develop Feb 25, 2024
@fchapoton fchapoton deleted the ruff_for_clusters branch February 25, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
c: combinatorics
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @tscrim @vbraun @mkoeppe