Skip to content

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 18, 2024

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@GiacomoPope
Copy link
Contributor

Is it worth replacing :trac: for :issue: in the doctests? Apologies if this has already been done.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 18, 2024

Is it worth replacing :trac: for :issue: in the doctests?

Not in this PR, but sure, why not

@kwankyu
Copy link
Collaborator

kwankyu commented Feb 19, 2024

Otherwise lgtm.

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 19, 2024

Thanks!

Copy link

Documentation preview for this PR (built with commit 8d3a589; changes) is ready! 🎉

@vbraun vbraun merged commit ccd3f8b into sagemath:develop Feb 25, 2024
vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 6, 2024
Following the PR sagemath#37385, I have
replaced all occurrences of `:trac:` with `:issue:`.

If changing so much in one PR is wrong and this should be done file by
file while working on other functions feel free to close this PR.

URL: sagemath#37390
Reported by: Giacomo Pope
Reviewer(s): Giacomo Pope, Kwankyu Lee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants