unit group of number field: do not expand product when S is empty #37226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
e9172d4 to
b7049bf
Compare
videlec
reviewed
Feb 7, 2024
| @@ -305,6 +305,13 @@ def __init__(self, number_field, proof=True, S=None): | |||
| sage: tuple(US(K(u)) for u in US.gens()) == US.gens() | |||
| True | |||
|
|
|||
| Bug #36386 (pari stack overflow while expanding units) | |||
There was a problem hiding this comment.
Should be
Bug :issue:`36386` (pari stack overflow while expanding units)::
sage: d = 12936642
There was a problem hiding this comment.
(ie there are three mistakes)
|
Documentation preview for this PR (built with commit 32c07c8; changes) is ready! 🎉 |
videlec
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #36386, at least for unit group computations (S-units will still suffer from the problem, or when the units are even larger). This PR does not address #31754, which would be a better (but more complicated) solution for the problem.
📝 Checklist
⌛ Dependencies
None