Skip to content

Fix names of Gentoo packages #37212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 2, 2024
Merged

Fix names of Gentoo packages #37212

merged 5 commits into from
Feb 2, 2024

Conversation

saraedum
Copy link
Member

@saraedum saraedum commented Jan 31, 2024 •
edited
Loading

Gentoo renamed some build tools in late 2023. We update the names here to fix the broken CI runs for Gentoo (that happen e.g. for cypari2.)

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion. (Offline discussion at SageDays, i.e., cypari builds are broken.)
  • I have created tests covering the changes. (There's already plenty of Gentoo CI in our setup that fails without this.)
  • I have updated the documentation accordingly. Nothing to do there.

⌛ Dependencies

@saraedum
Fix names of Gentoo packages
111fd7b 
Gentoo renamed some build tools in late 2023. We update the names here
to fix the broken CI runs for Gentoo (that happen e.g. for cypari2.)
@saraedum
Merge branch 'develop' into sys-devel-gentoo
0f6441d
@saraedum
Copy link
Member Author

Here's the new package: https://packages.gentoo.org/packages/dev-build/make

Here's the old package: https://web.archive.org/web/20230701000000*/https://packages.gentoo.org/packages/sys-devel/make

@saraedum saraedum requested a review from fchapoton January 31, 2024 22:29
@saraedum
Copy link
Member Author

@fchapoton I am waiting to see if the Gentoo CI manages to install make.

@fchapoton
Copy link
Contributor

maybe this specific CI needs to be triggered manually ?

saraedum added a commit to saraedum/cypari2 that referenced this pull request Feb 1, 2024
@saraedum
Test whether sagemath/sage#37212 fixes the build issues
8328f07
saraedum added a commit to saraedum/cypari2 that referenced this pull request Feb 1, 2024
@saraedum
Test whether sagemath/sage#37212 fixes the build issues
438d44e
dimpase
dimpase approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w.r.t. the package names (checked on a real gentoo box). If something in CI needs fixing then it could be done in a followup.

@dimpase
Copy link
Member

dimpase commented Feb 1, 2024

@kiwifb @orlitzky

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

Documentation preview for this PR (built with commit 57fb2a2; changes) is ready! 🎉

@saraedum
Copy link
Member Author

saraedum commented Feb 1, 2024 •
edited
Loading

@fchapoton, Gentoo tests pass with these changes over at cypari2: sagemath/cypari2#153

@kiwifb
Copy link
Member

kiwifb commented Feb 1, 2024

@kiwifb @orlitzky

LGTM

@vbraun vbraun merged commit a958e5b into sagemath:develop Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

+1 more reviewer

@dimpase dimpase dimpase approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
sd125 sage days 125
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.
6 participants
@saraedum @fchapoton @dimpase @kiwifb @vbraun @mkoeppe