unify alias substitute for subs #37210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…merator and denominator, unify subs signature, allow generator indices as keys consistently
|
I guess this "needs review", right ? |
|
Yes ! |
|
Documentation preview for this PR (built with commit da048df; changes) is ready! 🎉 |
fchapoton
approved these changes
Feb 6, 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 7, 2024
sagemathgh-37210: unify alias substitute for subs We unify the definitions as follows: * `substitute` is a method in `Element` which calls `self.subs` and passes all arguments along, and not defined anywhere else. * `subs` is the method that should be overwritten in the various element classes. Dependencies: sagemath#37143 URL: sagemath#37210 Reported by: Martin Rubey Reviewer(s): Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We unify the definitions as follows:
substituteis a method inElementwhich callsself.subsand passes all arguments along, and not defined anywhere else.subsis the method that should be overwritten in the various element classes.Dependencies:
#37143