Skip to content

Conversation

Cchenevi
Copy link

@Cchenevi Cchenevi commented Jan 31, 2024

Added the possibility to provide a rational slope parameter m in the GeneralizedTamariLattice method.
The lattice property is no longer conjectural so the check parameter is not necessary anymore.
Also updated the references.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@Cchenevi Cchenevi marked this pull request as ready for review January 31, 2024 18:01
@dimpase
Copy link
Member

dimpase commented Feb 1, 2024

@VivianePons

Copy link

github-actions bot commented Feb 2, 2024

Documentation preview for this PR (built with commit e103182; changes) is ready! 🎉

Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, c'est tout bon

@Cchenevi Cchenevi mentioned this pull request Feb 3, 2024
5 tasks
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 7, 2024
sagemathgh-37209: Added rational Tamari lattices
    
Added the possibility to provide a rational slope parameter m in the
GeneralizedTamariLattice method.
The lattice property is no longer conjectural so the check parameter is
not necessary anymore.
Also updated the references.

<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#37209
Reported by: Cchenevi
Reviewer(s): Frédéric Chapoton
@vbraun vbraun merged commit d548c00 into sagemath:develop Feb 13, 2024
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 18, 2024
sagemathgh-37221: Added the alt nu-tamari lattices
    
The alt nu-Tamari lattices are a generalization of the nu-Tamari
lattices. These lattices depend on a North-East path `\nu` and an
integer sequence `\delta`, which is an increment vector with respect to
`\nu`. A special choice of `\delta` gives the classical nu-Tamari
lattice, and another choice of `\delta` gives the inclusion order on
`\nu`-paths---North-East paths weakly above the path `\nu`.

These partial orders are implemented in the nu_tamari_lattice module.
The special case of the nu-Tamari lattice can be recovered by not
precising any vector delta, and benchmark tests suggest that this new
method is in fact slightly more efficient than the previous one, even in
this case.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

sagemath#37209
    
URL: sagemath#37221
Reported by: Cchenevi
Reviewer(s): Cchenevi, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 19, 2024
sagemathgh-37221: Added the alt nu-tamari lattices
    
The alt nu-Tamari lattices are a generalization of the nu-Tamari
lattices. These lattices depend on a North-East path `\nu` and an
integer sequence `\delta`, which is an increment vector with respect to
`\nu`. A special choice of `\delta` gives the classical nu-Tamari
lattice, and another choice of `\delta` gives the inclusion order on
`\nu`-paths---North-East paths weakly above the path `\nu`.

These partial orders are implemented in the nu_tamari_lattice module.
The special case of the nu-Tamari lattice can be recovered by not
precising any vector delta, and benchmark tests suggest that this new
method is in fact slightly more efficient than the previous one, even in
this case.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

sagemath#37209
    
URL: sagemath#37221
Reported by: Cchenevi
Reviewer(s): Cchenevi, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 22, 2024
sagemathgh-37221: Added the alt nu-tamari lattices
    
The alt nu-Tamari lattices are a generalization of the nu-Tamari
lattices. These lattices depend on a North-East path `\nu` and an
integer sequence `\delta`, which is an increment vector with respect to
`\nu`. A special choice of `\delta` gives the classical nu-Tamari
lattice, and another choice of `\delta` gives the inclusion order on
`\nu`-paths---North-East paths weakly above the path `\nu`.

These partial orders are implemented in the nu_tamari_lattice module.
The special case of the nu-Tamari lattice can be recovered by not
precising any vector delta, and benchmark tests suggest that this new
method is in fact slightly more efficient than the previous one, even in
this case.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

sagemath#37209
    
URL: sagemath#37221
Reported by: Cchenevi
Reviewer(s): Cchenevi, Frédéric Chapoton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants