-
-
Notifications
You must be signed in to change notification settings - Fork 656
Added rational Tamari lattices #37209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es, and update references
Documentation preview for this PR (built with commit e103182; changes) is ready! 🎉 |
fchapoton
approved these changes
Feb 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, c'est tout bon
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 7, 2024
sagemathgh-37209: Added rational Tamari lattices Added the possibility to provide a rational slope parameter m in the GeneralizedTamariLattice method. The lattice property is no longer conjectural so the check parameter is not necessary anymore. Also updated the references. <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37209 Reported by: Cchenevi Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 18, 2024
sagemathgh-37221: Added the alt nu-tamari lattices The alt nu-Tamari lattices are a generalization of the nu-Tamari lattices. These lattices depend on a North-East path `\nu` and an integer sequence `\delta`, which is an increment vector with respect to `\nu`. A special choice of `\delta` gives the classical nu-Tamari lattice, and another choice of `\delta` gives the inclusion order on `\nu`-paths---North-East paths weakly above the path `\nu`. These partial orders are implemented in the nu_tamari_lattice module. The special case of the nu-Tamari lattice can be recovered by not precising any vector delta, and benchmark tests suggest that this new method is in fact slightly more efficient than the previous one, even in this case. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies sagemath#37209 URL: sagemath#37221 Reported by: Cchenevi Reviewer(s): Cchenevi, Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 19, 2024
sagemathgh-37221: Added the alt nu-tamari lattices The alt nu-Tamari lattices are a generalization of the nu-Tamari lattices. These lattices depend on a North-East path `\nu` and an integer sequence `\delta`, which is an increment vector with respect to `\nu`. A special choice of `\delta` gives the classical nu-Tamari lattice, and another choice of `\delta` gives the inclusion order on `\nu`-paths---North-East paths weakly above the path `\nu`. These partial orders are implemented in the nu_tamari_lattice module. The special case of the nu-Tamari lattice can be recovered by not precising any vector delta, and benchmark tests suggest that this new method is in fact slightly more efficient than the previous one, even in this case. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies sagemath#37209 URL: sagemath#37221 Reported by: Cchenevi Reviewer(s): Cchenevi, Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 22, 2024
sagemathgh-37221: Added the alt nu-tamari lattices The alt nu-Tamari lattices are a generalization of the nu-Tamari lattices. These lattices depend on a North-East path `\nu` and an integer sequence `\delta`, which is an increment vector with respect to `\nu`. A special choice of `\delta` gives the classical nu-Tamari lattice, and another choice of `\delta` gives the inclusion order on `\nu`-paths---North-East paths weakly above the path `\nu`. These partial orders are implemented in the nu_tamari_lattice module. The special case of the nu-Tamari lattice can be recovered by not precising any vector delta, and benchmark tests suggest that this new method is in fact slightly more efficient than the previous one, even in this case. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies sagemath#37209 URL: sagemath#37221 Reported by: Cchenevi Reviewer(s): Cchenevi, Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility to provide a rational slope parameter m in the GeneralizedTamariLattice method.
The lattice property is no longer conjectural so the check parameter is not necessary anymore.
Also updated the references.
📝 Checklist
⌛ Dependencies