Skip to content

Fix RegularSequence.subsequence for zero sequence #37283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2024
Merged

Fix RegularSequence.subsequence for zero sequence #37283

merged 2 commits into from
Feb 25, 2024

Conversation

cheuberg
Copy link
Contributor

Fixes #37282

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Cc: @dkrenn

S17A05
S17A05 reviewed Feb 11, 2024
View reviewed changes
Copy link
Member

@S17A05 S17A05 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo, otherwise LGTM.

src/sage/combinat/regular_sequence.py Outdated
Comment on lines 765 to 766

Check that the zero sequence is handeled correctly (issue:`37282`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be "handled" instead of "handeled".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, fixed in 6b3480e.

@cheuberg cheuberg requested a review from S17A05 February 12, 2024 07:32
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 6b3480e; changes) is ready! 🎉

S17A05
S17A05 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@S17A05 S17A05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix - LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 18, 2024
ea91293 
sagemathgh-37283: Fix RegularSequence.subsequence for zero sequence
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
Fixes sagemath#37282

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
Cc: @dkrenn
    
URL: sagemath#37283
Reported by: cheuberg
Reviewer(s): cheuberg, Sebastian A. Spindler
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 19, 2024
2f40c52 
sagemathgh-37283: Fix RegularSequence.subsequence for zero sequence
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
Fixes sagemath#37282

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
Cc: @dkrenn
    
URL: sagemath#37283
Reported by: cheuberg
Reviewer(s): cheuberg, Sebastian A. Spindler
@vbraun vbraun merged commit 99fd4f4 into sagemath:develop Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@S17A05 S17A05 S17A05 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: combinatorics c: finite state machines t: bug
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.

RegularSequence.subsequence broken for zero sequence
4 participants
@cheuberg @S17A05 @vbraun @mkoeppe