Skip to content

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 10, 2024

These are some of the last remaining doctest warnings as of 10.3.beta7, as seen e.g. in https://github.com/sagemath/sage/pull/37250/files "Unchanged files with check annotations".

The ones not fixed here will need a solution for:

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the CI indicates a doctest warning in src/sage/geometry/polyhedron/backend_field.py line 93 that could be fixed in this PR: Variable 'p' referenced here was set only in doctest marked '# needs sage.rings.number_field sage.symbolic'

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 10, 2024

Indeed, thanks.

Copy link

Documentation preview for this PR (built with commit 9bfc29a; changes) is ready! 🎉

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 10, 2024

Thank you!

@vbraun vbraun merged commit f71381c into sagemath:develop Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants