Skip to content

Conversation

tornaria
Copy link
Contributor

@tornaria tornaria commented Feb 9, 2024

Add "needs sphinx" tags to some tests in src/sage_docbuild so there
is no failure when sphinx is not installed in the system.

See: #37263 (comment)

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.

Copy link

github-actions bot commented Feb 9, 2024

Documentation preview for this PR (built with commit 1b0ab3d; changes) is ready! 🎉

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 9, 2024

Who's doctesting src/sage_docbuild when sage-docbuild is not installed and why? sphinx is a dependency (install-requires) of sage-docbuild

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 9, 2024

But it does not hurt to add such # needs tags, so positive review.

@tornaria
Copy link
Contributor Author

tornaria commented Feb 9, 2024

Who's doctesting src/sage_docbuild when sage-docbuild is not installed and why? sphinx is a dependency (install-requires) of sage-docbuild

./sage -t --all, as explained in #37263 (comment), when using --disable-doc --enable-editable

@vbraun vbraun merged commit d3deb28 into sagemath:develop Feb 13, 2024
@tornaria tornaria deleted the needs_sphinx branch February 16, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants