Skip to content

Conversation

dcoudert
Copy link
Contributor

@dcoudert dcoudert commented Feb 8, 2024

This answer a question from https://ask.sagemath.org/question/75715/all_simple_paths-generates-attributeerror-for-graphs/

We make methods all_paths_iterator and all_simple_paths work for both Graph and DiGraph.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@jhpalmieri
Copy link
Member

This looks good to me.

@dcoudert
Copy link
Contributor Author

Thank you for the review.

@jhpalmieri
Copy link
Member

Thank you for implementing the fix!

Copy link

Documentation preview for this PR (built with commit df2af39; changes) is ready! 🎉

vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 18, 2024
sagemathgh-37260: extend `all_paths_iterator` and `all_simple_paths` to Graph
    
This answer a question from
https://ask.sagemath.org/question/75715/all_simple_paths-generates-
attributeerror-for-graphs/

We make methods `all_paths_iterator` and `all_simple_paths` work for
both `Graph` and `DiGraph`.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#37260
Reported by: David Coudert
Reviewer(s): John H. Palmieri
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 19, 2024
sagemathgh-37260: extend `all_paths_iterator` and `all_simple_paths` to Graph
    
This answer a question from
https://ask.sagemath.org/question/75715/all_simple_paths-generates-
attributeerror-for-graphs/

We make methods `all_paths_iterator` and `all_simple_paths` work for
both `Graph` and `DiGraph`.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#37260
Reported by: David Coudert
Reviewer(s): John H. Palmieri
@vbraun vbraun merged commit ffa8751 into sagemath:develop Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants