-
-
Notifications
You must be signed in to change notification settings - Fork 656
extend all_paths_iterator
and all_simple_paths
to Graph
#37260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vbraun
merged 2 commits into
sagemath:develop
from
dcoudert:graphs/extend_all_paths_iterator
Feb 25, 2024
Merged
extend all_paths_iterator
and all_simple_paths
to Graph
#37260
vbraun
merged 2 commits into
sagemath:develop
from
dcoudert:graphs/extend_all_paths_iterator
Feb 25, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks good to me. |
jhpalmieri
approved these changes
Feb 14, 2024
Thank you for the review. |
Thank you for implementing the fix! |
Documentation preview for this PR (built with commit df2af39; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 18, 2024
sagemathgh-37260: extend `all_paths_iterator` and `all_simple_paths` to Graph This answer a question from https://ask.sagemath.org/question/75715/all_simple_paths-generates- attributeerror-for-graphs/ We make methods `all_paths_iterator` and `all_simple_paths` work for both `Graph` and `DiGraph`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37260 Reported by: David Coudert Reviewer(s): John H. Palmieri
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 19, 2024
sagemathgh-37260: extend `all_paths_iterator` and `all_simple_paths` to Graph This answer a question from https://ask.sagemath.org/question/75715/all_simple_paths-generates- attributeerror-for-graphs/ We make methods `all_paths_iterator` and `all_simple_paths` work for both `Graph` and `DiGraph`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37260 Reported by: David Coudert Reviewer(s): John H. Palmieri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This answer a question from https://ask.sagemath.org/question/75715/all_simple_paths-generates-attributeerror-for-graphs/
We make methods
all_paths_iterator
andall_simple_paths
work for bothGraph
andDiGraph
.📝 Checklist
⌛ Dependencies