Skip to content

Conversation

orlitzky
Copy link
Contributor

@orlitzky orlitzky commented Feb 6, 2024

Add a few spkg-configure files, skip appnope when not on macOS, add an # optional tag, and add a few more packages to --disable-r and --disable-notebook.

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun
Copy link
Member

vbraun commented Mar 20, 2024

merge conflict

@orlitzky
Copy link
Contributor Author

rebased cleanly

@vbraun
Copy link
Member

vbraun commented Mar 21, 2024

merge conflict, please wait for the next beta

@orlitzky
Copy link
Contributor Author

Here's the thing: I'm gonna forget. Any plans to push whatever is conflicting to your vbraun/develop branch?

@orlitzky
Copy link
Contributor Author

Hey, I forgot. Rebase involved dropping three isolated commits that somebody else made first, so I think it's safe to set back to positive review.

Copy link

Documentation preview for this PR (built with commit 491b163; changes) is ready! 🎉

Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vbraun vbraun merged commit 2a7aeb6 into sagemath:develop Apr 12, 2024
@orlitzky orlitzky deleted the system-package-churn branch April 14, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants