-
-
Notifications
You must be signed in to change notification settings - Fork 656
Miscellaneous system package updates #37247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
13631a0
to
f6d9338
Compare
f6d9338
to
a834c4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
merge conflict |
a834c4e
to
7f3c6b5
Compare
rebased cleanly |
merge conflict, please wait for the next beta |
Here's the thing: I'm gonna forget. Any plans to push whatever is conflicting to your vbraun/develop branch? |
The tzdata package is only needed by pytz_deprecation_shim, which is already disabled when --disable-r is used.
7f3c6b5
to
491b163
Compare
Hey, I forgot. Rebase involved dropping three isolated commits that somebody else made first, so I think it's safe to set back to positive review. |
Documentation preview for this PR (built with commit 491b163; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Add a few spkg-configure files, skip appnope when not on macOS, add an
# optional
tag, and add a few more packages to--disable-r
and--disable-notebook
.