Skip to content

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Feb 4, 2024

as this appeared to be useful and missing during #sd125

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an optimization; otherwise LGTM. (Although the PR title is somewhat misleading.)

fchapoton and others added 2 commits February 5, 2024 10:02
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Copy link

github-actions bot commented Feb 5, 2024

Documentation preview for this PR (built with commit 3985bfc; changes) is ready! 🎉

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM. Sorry for the extra parenthesis.

vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 7, 2024
sagemathgh-37240: add one method to integer-valued polynomials
    
as this appeared to be useful and missing during #sd125

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
    
URL: sagemath#37240
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit 46ef3fd into sagemath:develop Feb 13, 2024
@fchapoton fchapoton deleted the variable_shift_in_B_basis branch February 14, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants