Skip to content

Conversation

fchapoton
Copy link
Contributor

This is adding a new method tp hypergeometric motives.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

@xcaruso
Copy link
Contributor

xcaruso commented Jan 31, 2024

Don't you want to give the possibility to the user to choose different variable names?

@fchapoton
Copy link
Contributor Author

bof, pas vraiment. utiliser u et v est relativement standard, je crois

@xcaruso
Copy link
Contributor

xcaruso commented Feb 1, 2024

Well, in the paper you cite, I cannot see any occurrence of u and v :-)

@xcaruso
Copy link
Contributor

xcaruso commented Feb 1, 2024

Thanks!
I won't complain that there is no doctest showing an example with different variable names...

Copy link

github-actions bot commented Feb 1, 2024

Documentation preview for this PR (built with commit 076f323; changes) is ready! 🎉

@fchapoton
Copy link
Contributor Author

merci !

@vbraun vbraun merged commit 7332a53 into sagemath:develop Feb 2, 2024
@fchapoton fchapoton deleted the E_polynomial branch February 3, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants