sage.categories.schemes: Fix modularization regression
#37179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit d2fa576; changes) is ready! 🎉 |
yyyyx4
approved these changes
Feb 1, 2024
|
Question for the future: How can we test for such problems? |
|
The "Build & Test" CI is already testing it on every PR (see section "Test modularized distributions"). For example, you can see the failure here: https://github.com/sagemath/sage/actions/runs/7706707056/job/21002697986#step:15:247 Currently the CI is configured so that this failure does not cause the "Build & Test" to fail. (#36498 is changing that -- waiting for review.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A module-level import is moved back inside methods so that the sagemath-categories distribution works again.
📝 Checklist
⌛ Dependencies