moving modular stuff to "CommutativeRing" class #37163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 8acc127; changes) is ready! 🎉 |
|
LGTM |
alexjbest
approved these changes
Jan 29, 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 30, 2024
sagemathgh-37163: moving modular stuff to "CommutativeRing" class as a step towards simplifying old coercion framework also adding some typing annotations ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#37163 Reported by: Frédéric Chapoton Reviewer(s): Alex J Best
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as a step towards simplifying old coercion framework
also adding some typing annotations
📝 Checklist