Skip to content

Minor ruff fixes in posets #37144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 2, 2024
Merged

Minor ruff fixes in posets #37144

merged 4 commits into from
Feb 2, 2024

Conversation

fchapoton
Copy link
Contributor

This is fixing a few of ruff suggestions (UP and PERF and ANN) in posets.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@fchapoton fchapoton changed the title Minor ruff posets Minor ruff fixes in posets Jan 23, 2024
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit b41465d; changes) is ready! 🎉

@fchapoton fchapoton requested a review from alexjbest January 30, 2024 08:24
alexjbest
alexjbest approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@alexjbest alexjbest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vbraun vbraun merged commit 27448fe into sagemath:develop Feb 2, 2024
@fchapoton fchapoton deleted the minor-ruff-posets branch February 3, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@alexjbest alexjbest alexjbest approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: combinatorics
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @alexjbest @vbraun @mkoeppe