-
-
Notifications
You must be signed in to change notification settings - Fork 656
Add devcontainer configs for sagemath/sagemath and sagemathinc/sagemath-core, add Docker section to installation manual #37029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Are there any specific assumptions here about my docker container that I should be aware of and document? Thanks. |
.devcontainer/downstream-docker-sagemathinc-sagemath-core/devcontainer.json
Show resolved
Hide resolved
Thanks. I've added a README here to at least reduce the chances we break things upstream: https://github.com/sagemathinc/cocalc-compute-docker/tree/main/src/sagemath/core |
I already asked a similar question in #37304 (see #37304 (comment)): Is there anything wrong with pointing to our CI images on This would give another chance to users who fail with some technical details in any of the Docker images (as in the case of the issue above). |
Documentation preview for this PR (built with commit 3b49938; changes) is ready! 🎉 |
Doesn't it make sense to add the new devcontainers I've tried to test the new Anyway, after long and hard experimentation following the instructions I found in #37534 I was able to obtain a working container in a local Windows folder with the new
BTW: On the Windows systems to which I have access there is Snagit installed (due to the fact that the snipping-tool that comes with Windows isn't really useful). Many of the VS Code keyboard shortcuts are overlaid by Snagit functionality, for example |
I tried it in codespaces. |
// * Otherwise, it does nothing. This is so that users can copy this devcontainer.json file as is | ||
// into their projects. | ||
"updateContentCommand": "if [ -d pkgs/sagemath-standard ]; then make configure && ./configure --prefix=/home/sage/sage/local --with-sage-venv; else echo 'Edit .devcontainer/devcontainer.json (updateContentCommand) to run project-specific startup commands'; fi", | ||
"extensions": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--prefix=/usr/local/sage/local
?
…links to Docker images
In https://groups.google.com/g/sage-announce/c/z83jqg9oQJE/m/4iePjwNvAQAJ, @williamstein announced the availability of https://hub.docker.com/r/sagemathinc/sagemath-core
Here we add a devcontainer configuration for it, based on the existing configuration for cocalc.
Likewise we add devcontainer configurations for the project's official Docker images (sagemath/sagemath:latest and :develop). We also update the README regarding the available tags.
New Docker section in the installation guide:
📝 Checklist
⌛ Dependencies