Skip to content

Conversation

fchapoton
Copy link
Contributor

Using Parent and CommutativeRing in the plural file

This is a little move towards getting rid of the old coercion framework.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

Copy link

github-actions bot commented Jan 7, 2024

Documentation preview for this PR (built with commit 1f95cb0; changes) is ready! 🎉

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 16, 2024
sagemathgh-37023: Parent in plural
    
Using `Parent` and `CommutativeRing` in the plural file

This is a little move towards getting rid of the old coercion framework.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37023
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 16, 2024
sagemathgh-37023: Parent in plural
    
Using `Parent` and `CommutativeRing` in the plural file

This is a little move towards getting rid of the old coercion framework.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37023
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 16, 2024
sagemathgh-37023: Parent in plural
    
Using `Parent` and `CommutativeRing` in the plural file

This is a little move towards getting rid of the old coercion framework.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37023
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
@vbraun vbraun merged commit cbf22d6 into sagemath:develop Jan 22, 2024
@fchapoton fchapoton deleted the parent_in_plural branch January 22, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants