Remove deprecated methods from QuaternionFractionalIdeal_rational #37088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#sd123 |
|
merge conflict |
|
Documentation preview for this PR (built with commit bba916a; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 27, 2024
sagemathgh-37088: Remove deprecated methods from QuaternionFractionalIdeal_rational This removes two methods of `QuaternionFractionalIdeal_rational` deprecated in sagemath#31583 (because of ambiguous behaviour; both could return either the left or the right order): - `quaternion_order()`; users should call `left_order()` or `right_order()` as appropriate - `ring()`; calling `ring()` still works but calls the method from the parent class, which returns the ambient quaternion algebra. URL: sagemath#37088 Reported by: Peter Bruin Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 29, 2024
sagemathgh-37088: Remove deprecated methods from QuaternionFractionalIdeal_rational This removes two methods of `QuaternionFractionalIdeal_rational` deprecated in sagemath#31583 (because of ambiguous behaviour; both could return either the left or the right order): - `quaternion_order()`; users should call `left_order()` or `right_order()` as appropriate - `ring()`; calling `ring()` still works but calls the method from the parent class, which returns the ambient quaternion algebra. URL: sagemath#37088 Reported by: Peter Bruin Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 30, 2024
sagemathgh-37088: Remove deprecated methods from QuaternionFractionalIdeal_rational This removes two methods of `QuaternionFractionalIdeal_rational` deprecated in sagemath#31583 (because of ambiguous behaviour; both could return either the left or the right order): - `quaternion_order()`; users should call `left_order()` or `right_order()` as appropriate - `ring()`; calling `ring()` still works but calls the method from the parent class, which returns the ambient quaternion algebra. URL: sagemath#37088 Reported by: Peter Bruin Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes two methods of
QuaternionFractionalIdeal_rationaldeprecated in #31583 (because of ambiguous behaviour; both could return either the left or the right order):quaternion_order(); users should callleft_order()orright_order()as appropriatering(); callingring()still works but calls the method from the parent class, which returns the ambient quaternion algebra.