Skip to content

some cleanup in overconvergent and quaternion #37072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2024
Merged

some cleanup in overconvergent and quaternion #37072

merged 2 commits into from
Jan 22, 2024

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Jan 16, 2024 •
edited
Loading

Two different things:

  • cleaning the file overconvergent/genus0, adding a TestSuite and making it pass ; getting rid of non-sensical gens_dict there

  • making quaternion algebra return a tuple of generators

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have created tests covering the changes.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit d97717d; changes) is ready! 🎉

dcoudert
dcoudert reviewed Jan 16, 2024
View reviewed changes
dcoudert
dcoudert approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fchapoton
Copy link
Contributor Author

so positive review ?

@dcoudert
Copy link
Contributor

Yes.

@vbraun vbraun merged commit 157a645 into sagemath:develop Jan 22, 2024
@fchapoton fchapoton deleted the some_cleanup_about_overconvergent_and_quaternion branch January 22, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dcoudert dcoudert dcoudert approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: algebra c: modular forms
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @dcoudert @vbraun @mkoeppe