Skip to content

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Jan 16, 2024

Towards the removal of ParentWithGens : use parent in number fields and in QQ

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@fchapoton fchapoton changed the title Use parent number field qq Use Parent in number fields and QQ Jan 16, 2024
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry; just one small while-we-are-at-it thing. You can set a positive review once changed or decided to ignore.

Copy link

Documentation preview for this PR (built with commit 936661d; changes) is ready! 🎉

@fchapoton
Copy link
Contributor Author

ok, setting to positive, thanks

@vbraun vbraun merged commit e31cc79 into sagemath:develop Jan 22, 2024
@fchapoton fchapoton deleted the use_parent_number_field_QQ branch January 22, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants