Skip to content

Deprecate is_Cone, is_LatticePolytope, is_Polyhedron, change uses to isinstance #37052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Deprecate is_Cone, is_LatticePolytope, is_Polyhedron, change uses to isinstance #37052

wants to merge 1 commit into from

Conversation

vamshipy
Copy link
Contributor

@vamshipy vamshipy commented Jan 13, 2024 •
edited
Loading

Depricated 3 functions is_Polyhedron, is_Cone and is_LatticePolytope and replaced using the python function "isinstance"

Fixes #34307

📝 Checklist

  • [x ] The title is concise, informative, and self-explanatory.
  • [x ] The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

The change seems simple so i don't know if there are any dependencies involved

Tried to change the comments(explanation) in the code don't know it counts as documentation
Would appreciate any kind of feedback from anyone

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 13, 2024

Thanks for working on this.

Note though that "deprecating" means to keep the function definitions but issue a warning whenever they are used. https://doc.sagemath.org/html/en/reference/misc/sage/misc/superseded.html

Deleting the function definitions needs to come in a second step, not earlier than a year after we have issued the deprecation warnings.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 9defda5; changes) is ready! 🎉

@vamshipy
Copy link
Contributor Author

Thanks for working on this.

Note though that "deprecating" means to keep the function definitions but issue a warning whenever they are used. https://doc.sagemath.org/html/en/reference/misc/sage/misc/superseded.html

Deleting the function definitions needs to come in a second step, not earlier than a year after we have issued the deprecation warnings.

Thank you for your feedback, I will keep working on this and ask for a review

@vamshipy vamshipy closed this Jan 14, 2024
@vamshipy
Copy link
Contributor Author

will create a fresh pr

@vamshipy vamshipy deleted the new-sage-code branch January 14, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
t: refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate is_Polyhedron, is_Cone, is_LatticePolytope
2 participants
@vamshipy @mkoeppe