Skip to content

Conversation

fchapoton
Copy link
Contributor

just fixing some pep8 and ruff suggestions in the modified file

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

Copy link

Documentation preview for this PR (built with commit 804f511; changes) is ready! 🎉

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine, but with normaliz broken because of e_antic not working, this cannot be tested properly...

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 20, 2023

e-antic waiting for review in #36901

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with the package fixes. LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 26, 2023
just fixing some pep8 and ruff suggestions in the modified file

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.

URL: sagemath#36921
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 27, 2023
sagemathgh-36921: various details in normaliz backend interface
    
just fixing some pep8 and ruff suggestions in the modified file

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36921
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 2, 2024
sagemathgh-36921: various details in normaliz backend interface
    
just fixing some pep8 and ruff suggestions in the modified file

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36921
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 5, 2024
sagemathgh-36921: various details in normaliz backend interface
    
just fixing some pep8 and ruff suggestions in the modified file

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36921
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit 0c535a3 into sagemath:develop Jan 14, 2024
@fchapoton fchapoton deleted the details_normaliz branch January 15, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants