Skip to content

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Dec 26, 2023

@cduston44

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@kwankyu
Copy link
Collaborator

kwankyu commented Feb 22, 2024

If this was tested at least once (since I can't test) and @cduston44 does not respond, then I will set this positive review.

Copy link

github-actions bot commented Apr 1, 2024

Documentation preview for this PR (built with commit 04bdf84; changes) is ready! 🎉

@kwankyu
Copy link
Collaborator

kwankyu commented Apr 5, 2024

Could this

https://github.com/aclemons/slackware-dockerfiles

be used to test this?

By the way, do we have many sage users on slackware linux distro? Or is @cduston44 the only one as far as known?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 5, 2024

It can be tested like our other Linux platforms, using tox -e docker-slackware-current-standard etc.; see tox.ini

(Note that the goal of this PR is not to make everything work. It just makes it testable.)

@kwankyu
Copy link
Collaborator

kwankyu commented Apr 6, 2024

If this was tested at least once (since I can't test) and @cduston44 does not respond, then I will set this positive review.

I forgot that I had made this comment :-)

OK. With this PR, slackware becomes testable in the sense that the test by tox proceeds further than before this PR.

For me, the test fails in building sage even with this PR, anyway.

@kwankyu
Copy link
Collaborator

kwankyu commented Apr 6, 2024

By the way, do we have many sage users on slackware linux distro? Or is @cduston44 the only one as far as known?

Perhaps non answerable... I asked because I guess that it is an unpopular linux distro.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 6, 2024

do we have many sage users on slackware linux distro?

I don't know any. When I did the initial porting to slackware, I did it only as an illustration of how to do the porting work for Sage using the Docker technology.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 6, 2024

Thanks for the review!

@vbraun vbraun merged commit 071499f into sagemath:develop Apr 8, 2024
@cduston44
Copy link

cduston44 commented Apr 10, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants