Skip to content

.devcontainer/downstream-archlinux-latest: Fix maxima #36959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2024
Merged

.devcontainer/downstream-archlinux-latest: Fix maxima #36959

merged 1 commit into from
Jan 14, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Dec 25, 2023 •
edited
Loading

Dev container configurations .devcontainer/downstream-* give easy access to Sage as provided by downstream packagers (see https://doc.sagemath.org/html/en/developer/portability_testing.html#using-our-pre-built-docker-images-for-development-in-vs-code, bottom).

Unfortunately maxima is defective when the archlinux sage package is installed in the official archlinux Docker container because of NoExtract directives that make the maxima help system inoperable.

Here we apply the same fix that we used in #36391 for the portability CI: Removing the NoExtract directives before installing the package.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2024

Documentation preview for this PR (built with commit 966fb86; changes) is ready! 🎉

@kwankyu
Copy link
Collaborator

kwankyu commented Jan 9, 2024

This is for the case that a user works in vs code with .devcontainer/downstream-archlinux-latest and attempts to build sage in the worktree. If I am right, is this a realistic case?

Anyway I tried, and got

...
[patch-2.7.5] Moving package files from temporary location /workspaces/sage-dev/local/var/tmp/sage/build/patch-2.7.5/inst to /workspaces/sage-dev/local
[patch-2.7.5] cp: preserving permissions for '/workspaces/sage-dev/local/./bin/patch': No data available
[patch-2.7.5] cp: preserving permissions for '/workspaces/sage-dev/local/./share/man/man1/patch.1': No data available
[patch-2.7.5] ************************************************************************
[patch-2.7.5] Error moving files for patch-2.7.5.

and did not even reach to the doc build stage...

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 9, 2024

Apologies for neglecting to write a proper PR description, fixed now.

Building Sage from source is not a goal in this container

@kwankyu
Copy link
Collaborator

kwankyu commented Jan 10, 2024

What I don't understand is this: "Removing the NoExtract directives before installing the package." Does installing the archlinux sage package fail because of the NoExtract directives?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 10, 2024

Does installing the archlinux sage package fail because of the NoExtract directives?

No, installation goes through, but it's broken at runtime.

@kwankyu
Copy link
Collaborator

kwankyu commented Jan 10, 2024

OK. This PR works well. The portability dev containers are very useful!

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 10, 2024

Thanks!

@vbraun vbraun merged commit c7a507d into sagemath:develop Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

@antonio-rojas antonio-rojas Awaiting requested review from antonio-rojas

Assignees

@mkoeppe mkoeppe

Labels
c: docker
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @kwankyu @vbraun