made changes to the documentaiton of developer in python3 print #36812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimpase
reviewed
Dec 5, 2023
| ... | ||
| SyntaxError: ... | ||
| - **Python3 print:** In SageMath code and doctests, adhere to Python 3 | ||
| syntax for the print function. Use parentheses as follows::: |
There was a problem hiding this comment.
why do you need ::: there? Maybe :: should do?
There was a problem hiding this comment.
I removed the : from end of the line.
There was a problem hiding this comment.
I would be more in favour of removing the sentence and the doctest completely, don't you agree @dimpase? There is already so much to read and I don't think that anybody will be assuming python 2 syntax nowadays.
There was a problem hiding this comment.
good idea. It's just very basic python.
|
@adrinospy, can you add the label "s:needs review"? (you may not have the appropriate rights, I don't know) |
No, no option is there to add label. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 10, 2023
sagemathgh-36812: made changes to the documentaiton of developer in python3 print removed the old python2 print statment information from the developer documentation Fixes sagemath#36807 removed the "Python3 print: Python3 syntax for print must be used in Sage code and doctests. If you use an old-style print in doctests, it will raise a SyntaxError:" and changed it with "In SageMath code and doctests, adhere to Python 3 syntax for the print function. Use parentheses as follows:" URL: sagemath#36812 Reported by: Aman Moon Reviewer(s): Aman Moon, Dima Pasechnik, Martin Rubey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed the old python2 print statment information from the developer documentation
Fixes #36807
removed the "Python3 print: Python3 syntax for print must be used in Sage code and doctests. If you use an old-style print in doctests, it will raise a SyntaxError:"
and changed it with
"In SageMath code and doctests, adhere to Python 3
syntax for the print function. Use parentheses as follows:"