Skip to content

avoid importing DiGraph from sage.graphs.graph #36736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2023
Merged

avoid importing DiGraph from sage.graphs.graph #36736

merged 1 commit into from
Dec 10, 2023

Conversation

dcoudert
Copy link
Contributor

We remove the top level import of DiGraph from src/sage/graphs/graph.py to prevent using from sage.graphs.graph import DiGraph.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 5560fa3; changes) is ready! 🎉

mkoeppe
mkoeppe approved these changes Nov 19, 2023
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcoudert
Copy link
Contributor Author

Thank you.

@vbraun vbraun merged commit 7cc2a4b into sagemath:develop Dec 10, 2023
@videlec videlec mentioned this pull request Aug 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mkoeppe mkoeppe mkoeppe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: graph theory t: refactoring
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.
3 participants
@dcoudert @mkoeppe @vbraun