build/pkgs/pari: require pari-2.5.14, drop tests for patched v2.5.13 #36732
Conversation
We currently check for either pari-2.5.14, or an unofficial (patched) version of pari-2.5.13 that is missing two bugs present in the upstream release. However, one of those bug-checks fails on macOS, making it impossible to use the system pari there. pari-2.5.14 has been out for a few months. Any distro fast enough to have backported patches to pari-2.5.13 will likely have pari-2.5.14 by now. On that assumption, we simply require pari-2.5.14 to fix the macOS issue, and hope it does not affect anyone still using a patched pari-2.5.13.
|
Documentation preview for this PR (built with commit d76d272; changes) is ready! 🎉 |
|
It looks great to me, but I really only use OS X + homebrew. I think we need feedback from people on other platforms about which versions of |
|
You can get some idea here: https://repology.org/project/pari/versions The only people affected are those with a patched pari-2.15.3. One would have to go digging to find out which patches are applied on the few distros that still have 2.15.3. I'm a strong proponent of supporting multiple versions of things, but patching them in sage and then requiring everyone else to apply the same patches and checking for them in |
What do the colors mean in that table? In particular, why are some of the 2.15.3 yellow and some red? |
The red ones are where no newer version is available on that distro. The yellow ones are where an old version exists, but a newer one is available too. (They key is on the repology homepage). For example, the Fedora 38 release has a yellow v2.15.13 because 2.15.14 is also available via the updates channel. |
|
Okay, let's move ahead with this. |
|
Note: should fix #36729. |
|
On Homebrew, one just has to install |
We currently check for either pari-2.5.14, or an unofficial (patched) version of pari-2.5.13 that is missing two bugs present in the upstream release. However, one of those bug-checks fails on macOS, making it impossible to use the system pari there.
pari-2.5.14 has been out for a few months. Any distro fast enough to have backported patches to pari-2.5.13 will likely have pari-2.5.14 by now. On that assumption, we simply require pari-2.5.14 to fix the macOS issue, and hope it does not affect anyone still using a patched pari-2.5.13.