Skip to content

make modform rings for triangle groups use Algebras #36703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 10, 2023
Merged

make modform rings for triangle groups use Algebras #36703

merged 3 commits into from
Dec 10, 2023

Conversation

fchapoton
Copy link
Contributor

This is using the category framework in a few more rings, namely modular forms for triangle groups.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@fchapoton fchapoton force-pushed the use_algebras_modform_triangle branch from 7dc678c to 5a0a079 Compare November 12, 2023 08:04
kwankyu
kwankyu reviewed Nov 21, 2023
View reviewed changes
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit f70bfb2; changes) is ready! 🎉

@fchapoton
Copy link
Contributor Author

any other comment ?

kwankyu
kwankyu approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps no.

@fchapoton
Copy link
Contributor Author

thanks a lot for your reviews

@vbraun vbraun merged commit 03487a1 into sagemath:develop Dec 10, 2023
@fchapoton fchapoton deleted the use_algebras_modform_triangle branch December 10, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees
No one assigned
Labels
c: modular forms t: refactoring
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @kwankyu @vbraun @mkoeppe