print more information about number-field orders #36760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwankyu
reviewed
Nov 24, 2023
kwankyu
reviewed
Nov 24, 2023
kwankyu
reviewed
Nov 24, 2023
83800ad to
8243f73
Compare
|
Documentation preview for this PR (built with commit 8243f73; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 27, 2023
sagemathgh-36760: print more information about number-field orders Currently, the `repr()` method for orders in number fields is not very useful: It prints the same information for all orders in a given field. In this patch we add the generators, and, for quadratic fields, the conductor of the order to the output of `repr()`. URL: sagemath#36760 Reported by: Lorenz Panny Reviewer(s): Kwankyu Lee, Lorenz Panny
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 2, 2024
sagemathgh-36760: print more information about number-field orders Currently, the `repr()` method for orders in number fields is not very useful: It prints the same information for all orders in a given field. In this patch we add the generators, and, for quadratic fields, the conductor of the order to the output of `repr()`. URL: sagemath#36760 Reported by: Lorenz Panny Reviewer(s): Kwankyu Lee, Lorenz Panny
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 5, 2024
sagemathgh-36760: print more information about number-field orders Currently, the `repr()` method for orders in number fields is not very useful: It prints the same information for all orders in a given field. In this patch we add the generators, and, for quadratic fields, the conductor of the order to the output of `repr()`. URL: sagemath#36760 Reported by: Lorenz Panny Reviewer(s): Kwankyu Lee, Lorenz Panny
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
repr()method for orders in number fields is not very useful: It prints the same information for all orders in a given field. In this patch we add the generators, and, for quadratic fields, the conductor of the order to the output ofrepr().