allow passing a generating set (not necessarily a basis) for quaternion ideals #36759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscrim
approved these changes
Dec 20, 2023
…al() and .right_ideal()
a72fee5 to
24f9b2d
Compare
|
Documentation preview for this PR (built with commit 24f9b2d; changes) is ready! 🎉 |
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 2, 2024
sagemathgh-36759: allow passing a generating set (not necessarily a basis) for quaternion ideals Most `.ideal()`-type methods in Sage take a list of generators. For quaternion orders, however, it is required that the given generators actually form a basis of the ideal. This is unexpected and inefficient, as it forces users to write more code in order to first compute a basis on their own. In this patch we add support for passing a list of generators instead of a basis. URL: sagemath#36759 Reported by: Lorenz Panny Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 5, 2024
sagemathgh-36759: allow passing a generating set (not necessarily a basis) for quaternion ideals Most `.ideal()`-type methods in Sage take a list of generators. For quaternion orders, however, it is required that the given generators actually form a basis of the ideal. This is unexpected and inefficient, as it forces users to write more code in order to first compute a basis on their own. In this patch we add support for passing a list of generators instead of a basis. URL: sagemath#36759 Reported by: Lorenz Panny Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most
.ideal()-type methods in Sage take a list of generators. For quaternion orders, however, it is required that the given generators actually form a basis of the ideal. This is unexpected and inefficient, as it forces users to write more code in order to first compute a basis on their own. In this patch we add support for passing a list of generators instead of a basis.