return Weierstrass scaling factor in base field for EllipticCurveIsogeny #36638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a43fe8 to
a508ff9
Compare
|
Documentation preview for this PR (built with commit a508ff9; changes) is ready! 🎉 |
|
I can review this but not until Tuesday -- it's a good idea and looks a trivial change in the code. |
|
Sorry for the delay, I forgot this one. It's good. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 4, 2023
… EllipticCurveIsogeny In the absence of pre- and post-isomorphisms, this value was returned as an `Integer` instead of in the base field, which is unexpected and sometimes causes things to break spontaneously. URL: sagemath#36638 Reported by: Lorenz Panny Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the absence of pre- and post-isomorphisms, this value was returned as an
Integerinstead of in the base field, which is unexpected and sometimes causes things to break spontaneously.