Skip to content

Replace relative imports by absolute ones in sage.libs except .ntl #36612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2023
Merged

Replace relative imports by absolute ones in sage.libs except .ntl #36612

merged 2 commits into from
Nov 5, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Oct 31, 2023

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

tobiasdiez
tobiasdiez reviewed Nov 1, 2023
View reviewed changes
src/sage/libs/pari/convert_sage_matrix.pyx Outdated
@@ -0,0 +1,105 @@
# sage_setup: distribution = sagemath-pari
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slipped in while cherry picking, I'll fix it

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

Documentation preview for this PR (built with commit 486508d; changes) is ready! 🎉

tobiasdiez
tobiasdiez approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For the next time, please just add another commit fixing the issue instead force-pushing everything. As a referee I don't want to check everything again, only the changed parts (i.e here that you removed the file). Thanks

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 2, 2023

As these commits are cherry-picks from #35095, it's more important for me to keep the commits in clear relation to the original commits.

@vbraun vbraun merged commit 2df7af7 into sagemath:develop Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mkoeppe mkoeppe

Labels
t: refactoring
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @tobiasdiez @vbraun