Dark Mode Compatibility: Improved Crystals Visibility #36695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 2748c2a; changes) is ready! 🎉 |
|
This works well, thanks very much. |
mkoeppe
approved these changes
Nov 11, 2023
883e05f to
e349b00
Compare
|
As the pull request is still pending, I would appreciate an update on its status. If there are any issues or feedback on my work, I am more than willing to address them promptly. Thank you for your time and assistance. |
|
It will be merged at the beginning of the next release cycle; https://doc.sagemath.org/html/en/developer/review.html#the-release-process |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 7, 2023
sagemathgh-36695: Dark Mode Compatibility: Improved Crystals Visibility Fixes sagemath#35740 Format `.png` images for dark mode compatibility  - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. URL: sagemath#36695 Reported by: cherry-1729-9090 Reviewer(s): Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35740
Format
.pngimages for dark mode compatibility