Skip to content

Codestyle improvements (mostly sort imports) #36687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2023
Merged

Codestyle improvements (mostly sort imports) #36687

merged 2 commits into from
Dec 10, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Nov 9, 2023 •
edited
Loading

Split out to preserve the incidental changes made in @tobiasdiez's original branch of #36372.

Author: Tobias Diez

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

tobiasdiez
tobiasdiez approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping upstreaming these changes.

Next time, please use the magic co-author comment to give proper attribution.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 9, 2023

Tobias, these are changes authored by you. You can't "positively review" them.

@tobiasdiez tobiasdiez changed the title Incidental edits from #36372 Codestyle improvements (mostly sort imports) Nov 9, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 9, 2023

I've rebased with --author

@tobiasdiez
Copy link
Contributor

Okay, then I misunderstood the purpose of this PR. Could you then please review these changes? Thanks!

dcoudert
dcoudert suggested changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it important to modify the order of the imports ? I'm missing something here.

src/sage/rings/polynomial/pbori/fglm.py
@@ -1,5 +1,5 @@
from .PyPolyBoRi import Polynomial, BoolePolynomialVector
from .pbori import FGLMStrategy, BooleSet
from .pbori import BooleSet, FGLMStrategy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid relative imports, no ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. But I prefer to do this migration in a separate PR.

@tobiasdiez
Copy link
Contributor

Why is it important to modify the order of the imports ? I'm missing something here.

There is of course nothing important in the import order. As with any code style fix, it merely improves the readability of the code (slightly). For example, it's easier to spot related imports. Perhaps I should also add that these changes were done automatically by ruff.

@dcoudert
Copy link
Contributor

Here also we have failing doctests due to nauty. I don't understand what's going on.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 58bd578; changes) is ready! 🎉

dcoudert
dcoudert approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So then, LGTM.

@tobiasdiez
Copy link
Contributor

Thanks for the review!

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 7, 2023
32e7d05 
sagemathgh-36687: Codestyle improvements (mostly sort imports)
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
Split out to preserve the incidental changes made in @tobiasdiez's
original branch of sagemath#36372.

Author: Tobias Diez

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36687
Reported by: Matthias Köppe
Reviewer(s): David Coudert, Tobias Diez
@vbraun vbraun merged commit 79598d3 into sagemath:develop Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

@dcoudert dcoudert dcoudert approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
t: refactoring
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.
4 participants
@mkoeppe @tobiasdiez @dcoudert @vbraun