Skip to content

ruff auto-fix for C4 in modular #36664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2023
Merged

ruff auto-fix for C4 in modular #36664

merged 2 commits into from
Dec 6, 2023

Conversation

fchapoton
Copy link
Contributor

this was scripted using

ruff check --select=C4 --fix src/sage/modular/

and is about simplifying list,set,dict comprehensions

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

DavidAyotte
DavidAyotte suggested changes Nov 6, 2023
View reviewed changes
@DavidAyotte
Copy link
Member

Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Documentation preview for this PR (built with commit 46a1441; changes) is ready! 🎉

@vbraun vbraun merged commit 9b1e18f into sagemath:develop Dec 6, 2023
@fchapoton fchapoton deleted the ruff_C4_modular branch December 6, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@DavidAyotte DavidAyotte DavidAyotte requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: modular forms t: refactoring
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @DavidAyotte @vbraun @mkoeppe