pkgs/sagemath-{bliss,coxeter3,...}: Move metadata from setup.cfg to pyproject.toml
#36564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 28, 2023 13:46
|
Hum, consequence of removing it from sage_setup. Fair enough. I thought I had reviewed this one already. I guess those PR got mixed up in my head. |
|
I think we should put this commit on #36562 instead |
kiwifb
approved these changes
Dec 6, 2023
|
Thank you! |
|
We will have to visit the MANIFEST.in again. I noticed a number of sdist includes .m4 files(sagemath-bliss, sagemath-standard for example) and some do include .gitignore (sagemath-standard for example). |
|
We can do that as part of #36649 |
Are you sure that's the right ticket? |
|
Documentation preview for this PR (built with commit bd825f0; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies
pkgs/sagemath-{objects,categories,environment,repl}: Move metadata fromsetup.cfgtopyproject.toml#36563