Skip to content

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Oct 26, 2023

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR (built with commit 479dae2; changes) is ready! 🎉

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 27, 2023

@tobiasdiez Any help here would be very welcome. I can't seem to get the matchers to match

@tobiasdiez
Copy link
Contributor

Since we have full control over the doctest output, instead of adding a problem matcher, I would add in the doctest writer a switch (checking for the CI env variable) and then print annotated logs. https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-error-message

Example: https://github.com/adrienverge/yamllint/blob/f63e56fd982e8dcee9f7849f80926e032cdabebd/yamllint/cli.py#L81-L88

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 28, 2023

OK, that's certainly something easy that we can do, thanks.
To human readers of our log files, it would add unfamiliar noise though, so there's some tradeoff to be considered.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 19, 2023

Closing in favor of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants